Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage #2

Merged
merged 2 commits into from
Dec 1, 2018
Merged

Update usage #2

merged 2 commits into from
Dec 1, 2018

Conversation

hashrock
Copy link
Contributor

I got this error when I executed the example on README.md :

test/test.ts:6:21 - error TS2322: Type 'string' is not assignable to type 'Uint8Array'.

6       req.respond({ body: "Hello World\n" });
                      ~~~~

  test/.deno/deps/https/deno.land/x/net/http.ts:43:3
    43   body?: Uint8Array;
         ~~~~
    The expected type comes from property 'body' which is declared here on type 'Response'

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zhmushan
Copy link
Contributor

you should put your code in an async function

@hashrock
Copy link
Contributor Author

@zhmushan Thank you! I fixed the example.

ry
ry approved these changes Dec 1, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM

@ry ry merged commit f574e3c into denoland:master Dec 1, 2018
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@hashrock @ry
Update usage (denoland/std#2)
6a7c01c 
Original: denoland/std@f574e3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hashrock @CLAassistant @zhmushan @ry